search

Matts / MacroKey

A mod that allows you to bind keys
17 stars 10 forks source link

Crash with loading game #47

Closed SeanChengN closed 6 years ago

SeanChengN commented 6 years ago

Describe the bug Crash with loading game.

To Reproduce Start game.

Expected behaviour Need to fix crash.

Screenshots Nope.

Desktop (please complete the following information):

Downloaded From CurseForge.com

Additional context Crash report: https://pastebin.com/0ZHTPzF8

Matts commented 6 years ago

Hi Sean,

Can you post your bindings.json file found in config/macrokey

SeanChengN commented 6 years ago

{"version":2,"macros":[{"umid":"bec1a4fe-1e91-43d2-b403-cf892c2c1af5","keyCode":79,"repeat":false,"command":"/stackup reload","active":true},{"umid":"d663fec9-f266-465b-b4d3-485378bf154d","keyCode":80,"repeat":false,"command":"/gamemode 1","active":true},{"umid":"bfc11d84-e232-484f-9e41-c0ef218953b7","keyCode":81,"repeat":false,"command":"/gamemode 0","active":true}],"layers":[]}

SeanChengN commented 6 years ago

Oh, I have figured it out now. If I remove the mod that command has been bound, MacroKey will crash. Could u ignore the mod that was removed?

Matts commented 6 years ago

Thanks for your report,

I found why this happens, and it's completely my fault, You were a BETA user.

I have added a new feature without thinking of them, sorry my bad. This is not related to removed mods, but related to an invalid file syntax.

For future support of different kinds of commands (ex. programming), I've modified the command string. This string now has an additional required parameter (type), this makes it a json object. Seeing as your bindingsfile.json is small, you are better of removing it and relaunching minecraft to add the ones you need.

I've added an item on the project roadmap to add a script to convert bindingfile versions

If you have any questions, please don't hesitate to reopen the ticket.