search

Mattshark89 / OpenFlight-VRC

MIT License
46 stars 33 forks source link

[BUG] Banking turns disables while flapping #120

Open Happyrobot33 opened 4 days ago

Happyrobot33 commented 4 days ago

When you trigger a flap, any banking turning you were doing will be paused until the flap action is finished. This seems to be related to this line here https://github.com/Mattshark89/OpenFlight-VRC/blob/86b9acedf0d1fb33959f9c388275d4d6a9bd01c4/Packages/com.mattshark.openflight/Runtime/Scripts/Flight/WingFlightPlusGlide.cs#L588-L593

When rotSpeedGoal is set to 0, rotation wont happen in update() https://github.com/Mattshark89/OpenFlight-VRC/blob/86b9acedf0d1fb33959f9c388275d4d6a9bd01c4/Packages/com.mattshark.openflight/Runtime/Scripts/Flight/WingFlightPlusGlide.cs#L360-L389 rotSpeedGoal being set to 0 seems to erroneously happen as the if statement its captured by is checking for flaps as part of its conditions https://github.com/Mattshark89/OpenFlight-VRC/blob/86b9acedf0d1fb33959f9c388275d4d6a9bd01c4/Packages/com.mattshark.openflight/Runtime/Scripts/Flight/WingFlightPlusGlide.cs#L522-L529