Mattshark89 / OpenFlight-VRC

MIT License
46 stars 33 forks source link

[BUG] Flight not working, panel does not show on/off/auto #33

Closed laxdragon closed 1 year ago

laxdragon commented 1 year ago

Describe the bug

Flight is not working correctly in my world. I installed using VCC and added the prefab from the menu. The in world tablet where it is supposed to report that the mode is on or off reports nothing, it also does not show any detected avatar data.

When building my world, unity reports this error.

[UdonSharp] Packages/com.mattshark.openflight/Runtime/Scripts/Detection/AvatarDetection.cs(88,69): Udon runtime exception detected!
  An exception occurred during EXTERN to 'VRCSDKBaseVRCPlayerApi.__GetBonePosition__UnityEngineHumanBodyBones__UnityEngineVector3'.
      Parameter Addresses: 0x00000003, 0x00000020, 0x00000079
  Object reference not set to an instance of an object

Screenshots

Screenshot 2023-06-23 104847

Desktop (please complete the following information):

Happyrobot33 commented 1 year ago

Just saw this, dont know why im not getting notifications for issues in this repository yet, but im going to look into this ASAP

Happyrobot33 commented 1 year ago

Relevant line https://github.com/Mattshark89/OpenFlight-VRC/blob/1b0c5f27c49323006325a16abd020c6ca73d2032/Packages/com.mattshark.openflight/Runtime/Scripts/Detection/AvatarDetection.cs#L88

Mattshark89 commented 1 year ago

Can confirm the latest version is not broken out of the box, did a quick fresh install myself of the system including the tablet (Full). Something odd must have happened in the Unity Project, still worth looking into

laxdragon commented 1 year ago

Thanks for spending so much time trying to figure this out. Unity has done something odd to my world due to a previous editor crash. Something somewhere is corrupt. Easier to just rebuild and move on.

Happyrobot33 commented 1 year ago

Un-Reproducable as of now by anyone but end user, changing status to not planned. If there is any updates to this feel free to comment in here about it

Happyrobot33 commented 1 year ago

reopening due to atomiklan also encountering this issue

Happyrobot33 commented 1 year ago

Reproduction steps: Place tablet far enough away from the player that upon the world loading it will be faded out automatically

Something about the way hiding it works it just seems to break the UI scripts

Happyrobot33 commented 1 year ago

possibly closed by latest beta

Happyrobot33 commented 1 year ago

Closed as fixed

laxdragon commented 1 year ago

All good here. I know this is closed. But just wanted to report the latest beta works for me. Good work!