search

Mattshark89 / OpenFlight-VRC

MIT License
46 stars 33 forks source link

Add Aviosaur Avatar #74

Closed fundale closed 10 months ago

Happyrobot33 commented 10 months ago

Need to fix the date and now the version given i just accepted a PR, and information on where the avatar comes from needs to be included aswell

fundale commented 10 months ago

Need to fix the date and now the version given i just accepted a PR, and information on where the avatar comes from needs to be included aswell

Can you elaborate on info for where the Avatar comes from? It's listed as made by Furality, and submitted by Orca, unless you're looking for a mention that it was modified?

Happyrobot33 commented 10 months ago

Need to fix the date and now the version given i just accepted a PR, and information on where the avatar comes from needs to be included aswell

Can you elaborate on info for where the Avatar comes from? It's listed as made by Furality, and submitted by Orca, unless you're looking for a mention that it was modified?

Specifically on like how to get it or a link to it

fundale commented 10 months ago

Need to fix the date and now the version given i just accepted a PR, and information on where the avatar comes from needs to be included aswell

Can you elaborate on info for where the Avatar comes from? It's listed as made by Furality, and submitted by Orca, unless you're looking for a mention that it was modified?

Specifically on like how to get it or a link to it

Well, Unfortunately you can't get the source files unless you are a Furality Sylva First Class User, or use a Public version uploaded by such people, I can add a referrer to people that do have that to contact Orca, but otherwise can't link to the original source files...

Also where would I put the referrer for that? I don't see a dedicated space in the Json for that...

jennytoo commented 10 months ago

Can you elaborate on info for where the Avatar comes from? It's listed as made by Furality, and submitted by Orca, unless you're looking for a mention that it was modified?

Since it's a public, I'd provide as much info as possible generally

Though looking at my previous logs, I've done it as Name by Author

In this case, Name by Creator, original model by Furality (link to vrc avatar page) would be reasonable (IMO)

Happyrobot33 commented 10 months ago

Need to fix the date and now the version given i just accepted a PR, and information on where the avatar comes from needs to be included aswell

Can you elaborate on info for where the Avatar comes from? It's listed as made by Furality, and submitted by Orca, unless you're looking for a mention that it was modified?

Specifically on like how to get it or a link to it

Well, Unfortunately you can't get the source files unless you are a Furality Sylva First Class User, or use a Public version uploaded by such people, I can add a referrer to people that do have that to contact Orca, but otherwise can't link to the original source files...

Also where would I put the referrer for that? I don't see a dedicated space in the Json for that...

This info is enough, the PR just needed some form of source information. It doesnt go into the json but this allows us to git blame for this PR if we ever need to do a hash version update

Happyrobot33 commented 10 months ago

not sure why the date check is failing....

jennytoo commented 10 months ago

not sure why the date check is failing....

Should be 2024-01-04