search

Matty9191 / ssl-cert-check

Send notifications when SSL certificates are about to expire.
GNU General Public License v2.0
719 stars 285 forks source link

parsing incorrectly #100

Open copenhaus opened 3 years ago

copenhaus commented 3 years ago

Hi, I'd like to report that whenever the Issuer has the character, comma, in its name, the output failed to parse the Issuer correctly.

As a sample: https://imgur.com/a/aq5kufb

Thanks...

woraccmsq commented 3 years ago

Yeah, I'm also faced with this, for example: ssl-cert-check -s acme.com/page -p 443

Host Status Expires Days

ERROR: The file named /var/tmp/cert.X0uptO is unreadable or doesn't exist ERROR: Please check to make sure the certificate for acme.com/page:443 is valid

woraccmsq commented 3 years ago

After update to 4.14: ssl-cert-check -s acme.com/page -p 443

Host Status Expires Days

acme.com/page:443 Unable to resolve the DNS name acme.com/page Unknown 0, 0 0

sandykadam commented 3 years ago

ERROR: The file named /var/tmp/cert.kK1m3s is unreadable or doesn't exist,ERROR: Please check to make sure the certificate for somedomain-name.net:443 is valid

Instead of showing this error, can we return user friendly msg e.g UNKNOWN or NA or INVALID CERTS

Because of this error, my whole dashboard is breaking

lewart3 commented 2 years ago

All,

1) Attached is a patch which fixes the original "Certificate Issuer with a comma" bug

2a) acme.com/page is an invalid hostname; use acme.com 2b) -p 443 is unnecessary, since that is the default

Enjoy! Daniel Lewart Urbana, Illinois

[certissuer.txt](https://github.com/Matty9191/ssl-cert-check/files/7896453/certissuer.txt

115