search

MattyIce / postpromoter

Steem bid-based voting bot written in JavaScript
MIT License
45 stars 89 forks source link

Empty Queue and Min_age edge case #82

Open officiallymarky opened 6 years ago

officiallymarky commented 6 years ago

I ran into an edge case that might be a simple fix if you have a few minutes you are mad at. It's not a critical issue, but I will leave it here anyway.

I have a smaller bot I help someone run, and it isn't uncommon for it to have zero bids at 100% due to the smaller size and 10% reward cap. It also has a min_age of 20 minutes, fairly typical of bots these days.

There is a scenario that may happen where a user submits a post that is 19 or fewer minutes old, and the bot currently has no bids and is at or near 100%.

The bid will be lost in limbo "next round queue" even when the post hits 20 minutes old due to the fact no further checks are made until another bid comes in. It will then execute that bid and then push the post from the next round to current round.

While this is a rare edge case it's something to think about. Not really critical and may never need to be fixed but mentioning it so I can get it off my mental plate and put it somewhere.

pjau86 commented 6 years ago

I ran into this issue today. My friend sent another bid and it kickstarted it like you said.