search

Mattzobricks / MattzoControllers

MattzoController firmware
20 stars 10 forks source link

Added manual brake signal in case a hub gets disconnected #36

Closed raymondbrink closed 1 year ago

raymondbrink commented 1 year ago

This change makes all hubs of a loco go into (manual) brake mode, if one of them fails. Once the last hub is connected again the manual brake is lifted.

Behavior while manually braking is identical to when e-braking: All motors are stopped and all lights are flashing.

Also had to re-introduce several imports of \, because otherwise code wouldn't compile!

Hilbert70 commented 1 year ago

With callbacks will work, but makes it harder to understand what is going on. I will try to make it more c++ like.

Hilbert70 commented 1 year ago

Please rebase to the current development version, this will remove the vector clutter!

Mattzobricks commented 1 year ago

Can I already test this pr, or will Ray or Hilbert do some changes before?

Hilbert70 commented 1 year ago

Please not to master!

raymondbrink commented 1 year ago

Please not to master!

This has been rectified in de PR. Request is now to merge into develop.