Add handling for red L9110 motor shield

nevesenin commented 9 months ago

Hi, after having some bad experiences (quality wise) with the recommended L9110 Motor shields (the blue ones) I ordered some of the red ones. Specifically these: https://botland.de/treiber-fur-schrittmotoren/9820-schrittmotortreiber-l9110-12v-08a-5904422338442.html I quickly discovered, that they don't work with the MotorShieldType::L9110 so I read through the documentation of the Shield and added the MotorShieldType::RED_L9110 which works fine. I'm not sure if RED_L9110 is a good naming for that shield, but I had no better idea how to describe the distinction between this and the common L9110 type. I'm also not super convinced, that I didn't miss a thing, that makes this PR unnecessary.

Mattzobricks commented 9 months ago

Thank you. I will have a look shortly.

nevesenin commented 5 months ago

Converted this to draft because I didn't test this very specific branch yet. I discovered that I missed to add a commit in the first place. Still have a hard time to get used to vscode (don't ask). Also I changed a bit on the commit in the meantime. Will explain in the comments.

Mattzobricks commented 4 months ago

Hi Merten, I saw that you did some things on the code. I will check it out and give you feedback, but at the moment I am too busy for that.

Thanks for your patience!

With kind regards, Matthias Runte

mattzobricks.com Dr. Matthias Runte Fon: +49 40 43270981 @.**@.>

www.mattzobricks.comhttp://www.mattzobricks.com/

Von: Merten Falk @.> Gesendet: Sonntag, 5. Mai 2024 06:46 An: Mattzobricks/MattzoControllers @.> Cc: Matthias Runte @.>; Assign @.> Betreff: Re: [Mattzobricks/MattzoControllers] Add handling for red L9110 motor shield (PR #65)

@nevesenin commented on this pull request.

In src/MTC4PF/src/main.cpphttps://github.com/Mattzobricks/MattzoControllers/pull/65#discussion_r1590207422:

@@ -345,10 +350,33 @@ void setMotorShieldPower(int motorShieldIndex, int motorPortIndex, int desiredPo

 // Motorshield specific constants and variables

 int irPowerLevel = 0; // Power level for the LEGO IR Receiver 8884

int invertedDesiredPowerLevel = ANALOG_WRITE_RANGE - desiredPowerLevel; // Power level for RED_L9110

The before-mentioned power level calculation for the red shield.

— Reply to this email directly, view it on GitHubhttps://github.com/Mattzobricks/MattzoControllers/pull/65#pullrequestreview-2039581119, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AXZVMQQRZBITI23QNNKD43DZAW2PXAVCNFSM6AAAAABAQ5YLD6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMZZGU4DCMJRHE. You are receiving this because you were assigned.Message ID: @.**@.>>

Mattzobricks commented 4 months ago

Ich habe einen größeren Teil meiner offenen Mattzobricks Bau-Projekte abgeschlossen und werde mich demnächst mal wieder mit dem Source Code beschäftigen. Dann werde ich auch Deinen PR reviewen.

Danke für Deine Geduld.

nevesenin commented 4 months ago

Kein Stress. Hat für mich keine Eile.

Mattzobricks commented 4 months ago

Hallo Merten, noch einmal vielen Dank für Deine Mitwirkung und Deinen Pull Request. Wir haben uns überlegt, ob wir die Anpassung mit in den Release-Strang einfließen lassen und uns (knapp) dagegen entschlossen. Der Grund liegt darin, dass wir vor dem Release 1.1 zu wenig Ressourcen haben, um die Sachen noch vernünftig testen zu können.

Danke für Dein Verständnis.

Mattzobricks / MattzoControllers

Add handling for red L9110 motor shield #65

With kind regards, Matthias Runte