search

Mauin / RxFingerprint

Android Fingerprint authentication and encryption with RxJava
Apache License 2.0
379 stars 81 forks source link

Makes result classes rely on auto value. #70

Closed serj-lotutovici closed 6 years ago

serj-lotutovici commented 7 years ago

Had to create a new subtype FingerprintExpressionResult (not convinced by the name), because auto-value prevents from creating subclasses from other subclasses.

P.S. Sorry for some re-formats, some files were using tabs instead of spaces.

Closes #69

serj-lotutovici commented 7 years ago

20% method count increase is a lot and adding auto-value later in the life of the lib is also an option, if that ever becomes necessary. On the other hand, it's hard to imagine any project that doesn't use progurad these days. In any case, I'm ok with both. Just tell me what you think is best at the moment.

Mauin commented 7 years ago

I'd go with implementing the toString methods manually for now. Should RxFingerprint expose more and more data classes at some point I would consider adding AutoValue to make that easier, but for now it seems to be much leaner to simply implement the method ourselves.

Mauin commented 6 years ago

Closing this in favor of #73