fix: dynamic storage info slow on windows

MauriceNino / dashdot

A simple, modern server dashboard, primarily used by smaller private servers

https://getdashdot.com/

MIT License

2.56k stars 94 forks source link

fix: dynamic storage info slow on windows #993

Closed Victor333Huesca closed 8 months ago

Victor333Huesca commented 8 months ago

For some reason I can't explain, the original order of fetching system information is slow using the Promise.all gathering method as opposed to two sequential awaits...

The reversed order does not suffer from this performance issue though...

Description

Related Issue(s)

MauriceNino commented 8 months ago

Okay, that is very weird. But thank you for investigating, and thank you for your contribution!

Victor333Huesca commented 8 months ago

For completeness, the impacted setup was a Windows 11 platform, this might vary on other system. I don't expect any performance regression on other platform, as this really looks like a bug with how systeminformation handles concurrent promises.

Thanks for the quick merge!

github-actions[bot] commented 8 months ago

:tada: This issue has been resolved in version 5.3.2

Please check the changelog for more details.