MauroDataMapper-NHSD / mdm-plugin-nhs-data-dictionary

Mauro Core Plugin for the NHS Data Dictionary
Apache License 2.0
0 stars 0 forks source link

Change paper bug fixes #95

Closed pjmonks closed 2 months ago

pjmonks commented 2 months ago

Two fixes around change papers.

Updated descriptions not appearing

Fixes #93

Seems to only be a problem on the NHSE Test server, possibly the wrong dependency for SAXTranformationFactory was being loaded. Forced the xalan library to be used instead, no idea if this works or not - it hasn't broken anything so far.

Remove duplicate Data Elements and Attributes

Fixes #88

When generating the change paper for CR1903, it contains multiple data sets. This repeated some of the Data Elements and Attributes in the summary of changes list because they are shared across multiple data sets e.g. "NHS NUMBER". Forced only unique lists to be used so nothing gets duplicated and breaks the DITA transform.

Testing

  1. Ensure that a Change Paper can be previewed/generated.
  2. Ingest the CR1903 branch and generate the DITA change paper for it. Then make sure it can be converted to PDF.