search

MauroDataMapper / mdm-ui

Web front-end for the Mauro Data Mapper
Apache License 2.0
7 stars 5 forks source link

Compare data model functionality broken #556

Closed jelenadreskai closed 2 years ago

jelenadreskai commented 2 years ago

Description

Cannot initiate Compare data model functionality

Steps to reproduce

  1. Login as and Administrator or Container Administrator (this may not work for other user types as well)
  2. Select data model in the tree structure, right click and select Compare to Another model
  3. Error is shown to the end user

Expected behavior

Compare UI shows up to the end user

Screenshots

image

Environment

Additional context

Message Http failure response for http://localhost:8084/api/tree/dataModels/DataModel/c781822f-9b59-4e02-bbb5-cedc17a672d7: 400 OK Status 400 Path http://localhost:8084/api/tree/dataModels/DataModel/c781822f-9b59-4e02-bbb5-cedc17a672d7

GBishop-PHSA commented 2 years ago

@olliefreeman We're seeing in the logs that the TreeInterceptor fails because of the uncommented code that throws the exception. (mc-9800)

The request is: [GET] /api/tree/dataModels/DataModel/ Where the model uuid is for a draft data model.

Is the UI supposed to be calling a different url to build the tree when using the compare function?

olliefreeman commented 2 years ago

moving this to the ui, as the UI is using the wrong endpoint. It should be

api/tree/$containerDomainType/$catalogueItemDomainType/$catalogueItemId

pjmonks commented 2 years ago

The incorrect endpoint was indeed used, this has been fixed now.