Error creating release build files for skia

[ghost]

Error message below. The fix was a small change in is_clang.py from

if ('clang' in subprocess.check_output('%s --version' % cc, shell=True) to

if ('clang' in subprocess.check_output('%s --version' % cc, shell=True, encoding="utf8")

Cheers

---

user at //gn/BUILDCONFIG.gn:84:14: Script returned non-zero exit code.
  is_clang = exec_script("//gn/is_clang.py",
             ^----------
Current dir: /home/user/Software/enve/third_party/skia/out/Release/
Command: python /home/user/Software/enve/third_party/skia/gn/is_clang.py gcc-7 g++-7
Returned 1.
stderr:

Traceback (most recent call last):
  File "/home/user/Software/enve/third_party/skia/gn/is_clang.py", line 14, in <module>
    if ('clang' in subprocess.check_output('%s --version' % cc, shell=True) and
Typeuser: a bytes-like object is required, not 'str'

[ghost]

Seems there are some other encoding issues going on here

make_data_assembly.py is screaming about encoding problems too, but I can't seem to get the right encoding.

Line 45 input_data = open(input_file, 'rb').read()

The print statement on the last line of that file also needed to be changed from print "Generated " + output_file to print("Generated " + output_file)

Spending quite a while trying to fix issues building.. I think I'll wait for a packaged release ;)

[MaurycyLiebner]

Are you using python 2? If I remember correctly it is the required version for building skia.

[irwant]

I get the same error when compiling skia using python 3.

[BobSynfig]

At the moment the "recipe" requires a version 16.04 of Ubuntu where "python" is "python2" During the configuration/install of skia, there are calls to different scripts and flavours of python:

!/usr/bin/python3

!/usr/bin/python2

!/usr/bin/python

!/usr/bin/env python

!/usr/bin/env python3

... which doesn't help