search

MausTec / edge-o-matic-3000

Firmware for the Edge-o-Matic 3000
GNU General Public License v3.0
103 stars 29 forks source link

Setting mode LOCKOUT_POST_MODE causes strange behavior #67

Closed enthusiasticimagination closed 6 months ago

enthusiasticimagination commented 7 months ago

On firmware v1.1.1.

It's possible to set the mode to LOCKOUT_POST_MODE via the WebSocket (by sending {"setMode": "LOCKOUT_POST_MODE"}), but this causes strange behavior on the EOM. It seems to behave similarly to Automatic mode, but there's no mode name shown at the top of the screen and no menu buttons are drawn at the bottom of the screen.

It seems that this mode used to be a distinct phase of Edging + Orgasm mode, but I guess that was replaced by the lock key in readings. This mode doesn't seem to be meaningful now.

MauAbata commented 6 months ago

Fascinating :o I'll try and fix our CI co that PR can get moving.

Did you check all the code base to make sure that enum value isn't being used elsewhere?

enthusiasticimagination commented 6 months ago

Did you check all the code base to make sure that enum value isn't being used elsewhere?

Yes - the only two instances are in the enum and in the other array that translates between enum values and mode names for setMode, both removed in #68.