Maushundb / quick-editor

This repo has been DEPRECATED. Please use https://atom.io/packages/code-peek
MIT License
25 stars 6 forks source link

empty panel #12

Closed spyshow closed 8 years ago

spyshow commented 8 years ago

hii i have a problem that when i press ctrl+shift+e ( windows user ) the panel open but it's empty as you can see in the photo 1

bakertesz commented 8 years ago

Hello, i have same problem. Any ideas ?

spyshow commented 8 years ago

No ... I switched to brackets On Oct 1, 2015 9:38 PM, "bakertesz" notifications@github.com wrote:

Hello, i have same problem. Any ideas ?

— Reply to this email directly or view it on GitHub https://github.com/Maushundb/quick-editor/issues/12#issuecomment-144811890 .

RenanOliv commented 8 years ago

I haven't tested it on a mac/linux environment but it looks like quick-editor is trying to get the css path file and failing on Windows.

The console throws an error that cannot read property 'getPath' of null in the quick-editor.coffee file, as you can see in the stack trace.

This bug occurred in a Windows 8.1 machine with Atom 1.0.19.

Studiomarcoli commented 8 years ago

Same problem here. Apple OS X Yosemite 10.10.5 Atom 1.10.19

Krzyrok commented 8 years ago

I have the same. When class (or id) is not defined in css, I have visible pane but with invisible path for adding this undefined selector (moving cursor or other interaction with Atom makes this path visible - but only part by part): 7eikedb

When I click 'Add' button, this class/id is added to the CSS - id correctly as #id, but class as .class: css2

If selector was present in CSS, then just empty pane is displayed.

And the worst thing: when I have open empty pane (just after adding new selector using 'Add' button) and I do some changes in CSS (and save it) and I close empty pane (with keyboard shortcut) then all my changes are gone - CSS is reverted to the moment when I added new id/class by 'Add' button in quick edit.

Atom: 1.0.19 with disabled all additional packages (just atom with core packages and your quick-editor) Windows 8.1

In seetings for your plugin firstly I had empty 'Styles Directory'. Then I tried to specify this. It didn't help.

prosf commented 8 years ago

Hello, I had the same problem: When the selector was found in the stylesheet the quick-editor panel opened but was empty. It seems that it is a css problem. Mine works okay now by changing the selector:

.quick-editor { overflow: hidden;

atom-text-editor { position: absolute; width: 100%; } }

to

.quick-editor { overflow: hidden;

atom-text-editor { position: absolute; width: 100%; height: 100%; } }

in the .atom\packages\quick-editor\styles\quick-editor.less

I haven't set the explicit styles directory ,in the quick-editor settings

Krzyrok commented 8 years ago

@prosf thanks, it's working now (after reloading atom) :)

prosf commented 8 years ago

That's nice :) I 'll do a pull request then

ProLoser commented 8 years ago

Yup definitely fixes it, thanks @prosf

prosf commented 8 years ago

Thanks for committing it ! @ProLoser