Maushundb / quick-editor

This repo has been DEPRECATED. Please use https://atom.io/packages/code-peek
MIT License
25 stars 6 forks source link

Changes (possibly) required for upcoming CoffeeScript upgrade #31

Closed Ingramz closed 5 years ago

Ingramz commented 6 years ago

Hello!

In Atom 1.23.0, the CoffeeScript dependency will be upgraded from version 1.11.1 to 1.12.7. To ensure that all packages will remain working the same way, we searched for CoffeeScript compile output differences from all Atom packages and found your package to be potentially affected by the update.

This pull request implements the fix mentioned in https://github.com/jashkenas/coffeescript/issues/4760#issuecomment-340001235, which is compatible with both versions.

It feels to me that the current code will remain working despite the compiled output takes slightly different approach. If you believe this is the case, feel free to just close this pull request and consider this just as a heads-up.

Please let me know if you have any questions.