Mavenomics / MavenWorks

Agile Dashboarding, anywhere
https://mavenworks.com
GNU General Public License v3.0
18 stars 2 forks source link

Alt+Shift+T (add new part shortcut) seldom works #44

Open YairMarcowMavenomics opened 5 years ago

quigleyj-mavenomics commented 5 years ago

x-ref with the old non-public JIRA as JOVIAN-648, no additional details on that issue.

quigleyj-mavenomics commented 4 years ago

After poking at it, I realized that some events don't appear to be propogating as we'd expect:

https://unixpapa.com/js/testkey.html

In that playground, try pressing "Alt T" and notice that there's a keydown and keyup pair for every key. Try the same thing with "Alt Shift T", and notice that we don't actually see a keydown event for the "T" in that shortcut.

I suspect this is an issue with key masking- certain key combinations can't fire together on most matrix keyboards. On this particular keyboard, for instance, I cannot enter "T" when both shift keys are pressed. And when both alt keys are pressed, most of the alphabet becomes inaccessible.

The easiest solution for this is to change the shortcut- maybe to a chord like Ctrl E, T? Or for consistency, Alt E, T/Alt T, T, etc.