Mavenomics / MavenWorks

Agile Dashboarding, anywhere
https://mavenworks.com
GNU General Public License v3.0
18 stars 2 forks source link

Don't render parts for self-originated changes #52

Open quigleyj-mavenomics opened 5 years ago

quigleyj-mavenomics commented 5 years ago

This PR includes an experimental change to evaluate the impact of #36, which proposes not rendering parts that update their own options.

First impressions are positive so far- the SlickGrid in particular seems more stable and performant. It seems like the wrapper was written for this execution model, which makes sense considering it's history in the enterprise platform.

We'll need to test a variety of UDPs and dashboards to ensure that this doesn't cause unworkable breakage, and going through the process of fixing UDPs that are broken by this change should tell us more about the real-world, practical impact of this.

Post-experiment To Do

After that's done, there's still some followup before this can be merged onto mainline:

Will fix #36.

Known breakages: