Mavenomics / MavenWorks

Agile Dashboarding, anywhere
https://mavenworks.com
GNU General Public License v3.0
18 stars 2 forks source link

Proposal: Binding expression changes should not unconditionally force a refresh #58

Open quigleyj-mavenomics opened 5 years ago

quigleyj-mavenomics commented 5 years ago

Presently, pressing "apply" on the Query Editor will always refresh the part, even if the query didn't change. This is because there is no bailout mechanism in OptionsBag#setBinding(), so any sets will always stale the options bag.

It's unclear what the downsides of this change are, so it may get some experimentation before we implement it. My plan is to push this change to the same branch that #36 is being tested on, and see if any breakages or issues there arise from this change.

The user facing impact of this change is primarily that queries will not re-run when you press "Apply" unless you actually change them. This can have impacts on dev cycles (especially when working against live data), since you no longer have a convenient mechanism to force a re-run that's right on the editor surface (You have to change your focus to the part, and refresh it using Alt+R or the context menu, then move back to the query editor).