Maveo / Spark

A little Discord companion for your server. 🤖
https://maveo.github.io/Spark/
Other
4 stars 3 forks source link

Userfriendly Error message: No direct message possible #63

Closed KGS501 closed 2 years ago

KGS501 commented 2 years ago

Describe the Bug

If a user hasn't enabled the "allow direct messages from server members" setting, Spark is not able to send users direct messages when creating a promo code. Spark currently gives out a cryptic error message, which is hard to interpret for regular users.

To Reproduce

Use an account, which has not interacted with Spark before

  1. Go to user settings -> Privacy & Safety
  2. Disable "allow direct messages from server members" under server privacy defaults
  3. Use the /promo command

Expected behaviour

Spark should give an easy-to-understand explanation of what went wrong and what the user has to do to recieve the direct message in the server text-channel in which the command was used.

Screenshots

image

skillor commented 2 years ago

I checked the use-case /promo and the send dm emoji reaction. Anywhere else this could be relevant? @KGS501

skillor commented 2 years ago

93fd7a43ac830350991ef1b722205a94a2623409

KGS501 commented 2 years ago

Potentially anytime Spark tries to send a direct message to a user with this disabled setting. Message reactions can be configured to send dms aswell and other future use cases

skillor commented 2 years ago

Potentially anytime Spark tries to send a direct message to a user with this disabled setting. Message reactions can be configured to send dms aswell and other future use cases

No they can not. And I can't fix the future lol

KGS501 commented 2 years ago

emoji-reaction*