search

Mavrogiannis-Ioannis / dsmmR

GNU General Public License v3.0
0 stars 1 forks source link

Bump required minimum R version to 3.5.0 #1

Closed Bisaloo closed 8 months ago

Bisaloo commented 8 months ago

for use of isFALSE():

https://github.com/Mavrogiannis-Ioannis/dsmmR/blob/ea8d149f2adcdc8261810a22a1f3d96fed0c3d6f/R/utils.R#L33

This is part of https://github.com/openjournals/joss-reviews/issues/5572.

Mavrogiannis-Ioannis commented 8 months ago

Hello @Bisaloo thank you for your comment. It is the first time I am using this Bump action, but I understand you want to change something in this line 33 of dsmmR/R/utils.R ? Can you extend on it? Thank you, Ioannis

Bisaloo commented 8 months ago

Hi @Mavrogiannis-Ioannis, in the function is_logical(), you use the base R function isFALSE(). This function is a somewhat "recent" addition to the language in R version 3.5.0, released in 2018.

This dependency to R 3.5.0 needs to be specified in the DESCRIPTION file, which is what this pull request does.

Does it make sense?

You can find more info about minimum R version dependency in R packages in this blog post: https://blog.r-hub.io/2022/09/12/r-dependency/

Mavrogiannis-Ioannis commented 8 months ago

Perfect! Nice catch, thank you @Bisaloo. I thought I had checked all dependencies, but this one slipped away from me. If you see anything else, please feel free to comment - I'll change it right away. Ioannis