search

Mawi137 / ngx-image-cropper

An image cropper for Angular
MIT License
778 stars 207 forks source link

Cannot get it working with Ivy #237

Closed jmesa-sistel closed 4 years ago

jmesa-sistel commented 4 years ago

Maybe it is my fault but I'm trying to get it working with angular9-rc4 and I get the error: ERROR in Tried to overwrite ./node_modules/ngx-image-cropper/lib/component/image-cropper.component.d.ts.__ivy_ngcc_bak with an ngcc back up file, which is disallowed. Anyone else is testing with Ivy?

kolkov commented 4 years ago

What version of RC you are using?

jmesa-sistel commented 4 years ago

@kolkov It is in the first line of the issue: angular9-rc4

Mawi137 commented 4 years ago

Hi there, once Angular 9 is released I'll also build this lib with Angular 9. Hopefully somewhere soon :)

jmesa-sistel commented 4 years ago

@Mawi137 I just was testing to be sure my project was fine. The error is weird because I see you use ng-packagr so in theory is Ivy compatible, that is the reason I was asking. I suspect the problem is on my side.

kolkov commented 4 years ago

I use this package with Ivy enabled in my project, this works fine with Angular 9.0.0-rc.5. Thanks.

jmesa-sistel commented 4 years ago

@kolkov I know you just tell that Ivy is enabled, but if you use ng-update the updater disable Ivy in tsconfig.app.json by default, can you verify that Ivy is not disabled? Have you try to compile node_modules for Ivy? ngcc-compilation The error happens in postinstall script also. (npm run postinstall)

kolkov commented 4 years ago

@jmesa-sistel Ivy enabled by default in next 9 version. My project compiled with ngcc. And I see Ivy code in source files.

jmesa-sistel commented 4 years ago

@kolkov Thks for confirmation. I'll check my project again.