search

Max-Github / FireFoxInvertColors

A simple addon that will invert a web page colors.
GNU General Public License v3.0
56 stars 15 forks source link

Invert page and/or images independently #30

Open franckspike opened 5 years ago

franckspike commented 5 years ago

Still missing default value initialization, but maybe you want to integrate it, François

Max-Github commented 5 years ago

What would be the purpose to invert the images only?

franckspike commented 5 years ago

I invert the colors of my whole system, but I want my images to be reinverted back to normal, I first thought your add-on might do this, then I realized you provided to source code :-)

Max-Github commented 5 years ago

That is a good reason for this feature.

I have looked at the changes, would you be able to update the options page to have the following 2 checkboxes (instead of the radio buttons):

Invert Text: (default on) Invert Images: (default on)

And add logic to enable both these options if nothing is enabled for inversion.

This is to avoid having too many options for the radio buttons in the futures, as each extra option would result in having (n)! number of buttons vs just n check boxes.

franckspike commented 5 years ago

I was thinking that we should be able to activate on/off the add-on processing, but then I realized that the options need to be saved and not changed for a later activation. So this leads to the possibility of having it activated but with all the options doing nothing and would be confusing that the add-on did nothing upon activation or deactivation... That's why I came with the radio button solution, even if I agree preferring eigenvalue toggling over a cross product flat listed list of choices...

Then thinking about it yesterday I came with the idea to display a colored warning box message when none of the eigen (independent) processing option has been selected, but I'd prefer making it impossible to use such an option selection set...

What are your thoughts ?

Max-Github commented 5 years ago

I prefer to keep things as simple as possible regarding options. Which includes having the least amount of options.

As for the case where a user disables all inversions, the simplest thing would be just revert to the default state when everything is inverted. There is no need for warning boxes. It just corrects the situation.

franckspike commented 5 years ago

Agreed

De : Max notifications@github.com Envoyé : Wednesday, March 6, 2019 1:59:19 PM À : Max-Github/FireFoxInvertColors Cc : Franckspike; Author Objet : Re: [Max-Github/FireFoxInvertColors] Invert page and/or images independently (#30)

I prefer to keep things as simple as possible regarding options. Which includes having the least amount of options.

As for the case where a user disables all inversions, the simplest thing would be just revert to the default state when everything is inverted. There is no need for warning boxes. It just corrects the situation.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/Max-Github/FireFoxInvertColors/pull/30#issuecomment-470231997, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AESKoG6DpHNDBPX3SN1TW6YefdJZa3Duks5vUBAHgaJpZM4bdcfX.

MichaelSantosDev commented 5 years ago

I use color inversion too but, I'm trying set all my APPS, SO and etc with dark/high contrast themes. Because of this, I started to use your addon MAX, first at all, thanks for developed it. This kind of option will be amazing, I would like invert colors of page, but keep original colors of images and videos. Thanks again.