BUG: Line height 2em breaking design

MaxArt2501 / share-this

Medium-like text selection sharing without dependencies

https://maxart2501.github.io/share-this/

MIT License

808 stars 53 forks source link

Closed jimblue closed 6 years ago

jimblue commented 7 years ago

Hi @MaxArt2501 !

I have a new train coding chalenge for you haha.

There is a little gap in the bottom of each buttons. (easier to see on hover)

The problem come from the line-height property set to 2em on .share-this-popover>ul>li. It should be reset to 1 without unit.

That's it 😄

jimblue commented 7 years ago

line-height-0 line-height-2

MaxArt2501 commented 6 years ago

I'm not able to reproduce the issue. In the example page it works as intended.

Can you provide a minmal example?

MaxArt2501 commented 6 years ago

Closing as unable to reproduce the case.

jimblue commented 6 years ago

I've try to understand it but I didn't... I'll come back with more information asap.

Thanks