search

MaxArt2501 / share-this

Medium-like text selection sharing without dependencies
https://maxart2501.github.io/share-this/
MIT License
808 stars 53 forks source link

Support for hiding the popover #30

Open Saheb opened 6 years ago

Saheb commented 6 years ago

Once the action is performed, it should be possible to call hide/close/killPopover. At the moment, it's only possible to destroy.

Saheb commented 6 years ago

I just moved killPopover into the return statement, that seemed to expose that function and works as expected. Not sure if that's the right way.

But, I think that should be the default behavior across sharers, what do you think about that?

jpoles1 commented 6 years ago

I also think this would be a helpful feature! Can you explain a bit more how you got it done @Saheb?