search

MaxAst / expo-share-extension

Expo config plugin for creating iOS share extensions with a custom view.
MIT License
161 stars 4 forks source link

How does the view update? #10

Closed robertherber closed 4 months ago

robertherber commented 4 months ago

I'm getting it to show but not to update after initially showing the view. I guess live reload might be asking too much - but what is the update logic like?

MaxAst commented 4 months ago

Hey @robertherber! Hot reload should work the same as in the main app (see video). I'm surprised it doesn't work for you. I assume you already double checked the installation steps in the README? And have you tried cloning the repo and running one of the examples?

https://github.com/MaxAst/expo-share-extension/assets/13224092/864f08c1-2b2c-408e-98e0-f4e9a24f400e

MaxAst commented 4 months ago

if you can provide a repro, I'd also be happy to take a look

robertherber commented 4 months ago

I upgraded to the latest version and added experimentalImportSupport: false in the metro config and it loads now.. :)

A note about the metro config though, I'm running into a maximum callstack exceeded exception when setting inlineRequires: true. Might be totally unrelated to this package though, but it seems like it's not really required?

MaxAst commented 4 months ago

happy to hear you got it working! Re inlineRequires, okay interesting, thanks for the heads up! tbh I can't remember exactly why I added it, will try removing it to see if everything still works as expected without it. If so, I'll remove it from the README

MaxAst commented 4 months ago

Apparently inlineRequires is enabled by default since v0.64. I'll remove it from the README. But that also means that your callstack exceeded exception might be caused by something else