MaxAst / expo-share-extension

Expo config plugin for creating iOS share extensions with a custom view.
MIT License
186 stars 4 forks source link

Can I use with `@react-native-firebase/crashlytics`? #38

Open Spice-Z opened 1 month ago

Spice-Z commented 1 month ago

I just notice the build will fail with this log when the project has @react-native-firebase/crashlytics in dependencies.

[RUN_FASTLANE] ❌ error: Could not get GOOGLE_APP_ID in Google Services file from build environment

Other react-native-firebase libraries will work as this repo's example shows. Is there any way to use @react-native-firebase/crashlytics ?

My environment is like this (result of react-native info):

System:
  OS: macOS 14.5
  CPU: (8) arm64 Apple M1
  Memory: 133.34 MB / 16.00 GB
  Shell:
    version: "5.9"
    path: /bin/zsh
Binaries:
  Node:
    version: 22.3.0
    path: ~/.nodenv/versions/22.3.0/bin/node
  Yarn: Not Found
  npm:
    version: 10.8.1
    path: ~/.nodenv/versions/22.3.0/bin/npm
  Watchman:
    version: 2024.07.01.00
    path: /opt/homebrew/bin/watchman
Managers:
  CocoaPods:
    version: 1.14.3
    path: /Users/main/.rbenv/shims/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 23.5
      - iOS 17.5
      - macOS 14.5
      - tvOS 17.5
      - visionOS 1.2
      - watchOS 10.5
  Android SDK: Not Found
IDEs:
  Android Studio: 2021.2 AI-212.5712.43.2112.8815526
  Xcode:
    version: 15.4/15F31d
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 17.0.2
    path: /usr/bin/javac
  Ruby:
    version: 3.2.2
    path: /Users/main/.rbenv/shims/ruby
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 18.2.0
    wanted: 18.2.0
  react-native:
    installed: 0.74.3
    wanted: 0.74.3
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: Not found
  newArchEnabled: Not found
iOS:
  hermesEnabled: Not found
  newArchEnabled: Not found

I'm using Expo v51.

MaxAst commented 1 month ago

sounds like an issue with your google services file's contents and not this library. Did you verify that you have GOOGLE_APP_ID in your services file?

Spice-Z commented 1 month ago

My two services file have GOOGLE_APP_ID. And the build will success just removing @react-native-firebase/crashlytics from deps with the same services files.

Spice-Z commented 1 month ago

Can you build the with-firebase example after adding @react-native-firebase/crashlytics in deps?

MaxAst commented 3 weeks ago

Hey @Spice-Z, looks like crashlytics requires some extra setup steps in Xcode: https://firebase.google.com/docs/crashlytics/get-started?platform=ios#set-up-dsym-uploading. I don't have a need for crashlytics right now, so won't invest time into adding it. But I'd be happy to review a PR, if you'd like to contribute