search

MaxBazarov / demo-station-plugin

Plugin for Figma
4 stars 1 forks source link

External Link Interaction Not Working #6

Open lucasmarambio opened 9 months ago

lucasmarambio commented 9 months ago

Hello,

I've encountered an issue with the latest release of the Demo Station plugin. In my Figma prototype project, I have a frame that includes a click interaction to open an external link. This interaction works as expected when played within Figma. However, after exporting the prototype using the latest version of Demo Station for publishing on my website, the external link interaction no longer functions.

image

This issue wasn't present in the previous versions of the plugin. Could you please investigate this?

Thank you for your attention to this matter.

Best regards, Lucas

MaxBazarov commented 9 months ago

Thanks for the report! Will investigate it ASAP.11 дек. 2023 г., в 19:24, Lucas Marambio @.***> написал(а): Hello, I've encountered an issue with the latest release of the Demo Station plugin. In my Figma prototype project, I have a frame that includes a click interaction to open an external link. This interaction works as expected when played within Figma. However, after exporting the prototype using the latest version of Demo Station for publishing on my website, the external link interaction no longer functions. image.png (view on web) This issue wasn't present in the previous versions of the plugin. Could you please investigate this? Thank you for your attention to this matter. Best regards, Lucas

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

MaxBazarov commented 9 months ago

Ok, the problem fixed. Please, restart Figma to be sure you have got the latest plugin version.

Sorry for disturbing.

11 дек. 2023 г., в 19:45, Max Bazarov @.***> написал(а):

Thanks for the report! Will investigate it ASAP.

11 дек. 2023 г., в 19:24, Lucas Marambio @.***> написал(а):



Hello,

I've encountered an issue with the latest release of the Demo Station plugin. In my Figma prototype project, I have a frame that includes a click interaction to open an external link. This interaction works as expected when played within Figma. However, after exporting the prototype using the latest version of Demo Station for publishing on my website, the external link interaction no longer functions.

image.png (view on web) https://github.com/MaxBazarov/demo-station-plugin/assets/9018508/a8995a5e-1a4d-4cf7-8b68-aba6e6bd542a This issue wasn't present in the previous versions of the plugin. Could you please investigate this?

Thank you for your attention to this matter.

Best regards, Lucas

— Reply to this email directly, view it on GitHub https://github.com/MaxBazarov/demo-station-plugin/issues/6, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEMQVAWE5EKF63XHTVTO7KLYI4XSFAVCNFSM6AAAAABAQBHRPKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGAZTMMBUHA2DOMY. You are receiving this because you are subscribed to this thread.

lucasmarambio commented 9 months ago

Thanks for the quick reply and fix. It's working now, but it seems that the "open in new tab" action is still not working.

lucasmarambio commented 9 months ago

I'm also seeing an strange behavior with the frames exported as it seems that the navigation between frames does not work well now. When I click a frame that has the Navigate to another frame, the first frame does not hide, and the other one loads behind the first one. This behavior does not happen when playing the prototype on figma.

MaxBazarov commented 9 months ago

Ohh. I was too fast with the latest fix. Merged uncompleted features into a release branch. Going to fix again. 11 дек. 2023 г., в 22:28, Lucas Marambio @.***> написал(а): I'm also seeing an strange behavior with the frames exported as it seems that the navigation between frames does not work well now. When I click a frame that has the Navigate to another frame, the first frame does not hide, and the other one loads behind the first one. This behavior does not happen when playing the prototype on figma.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

MaxBazarov commented 9 months ago

I just uploaded the update. Not sure that it fixes your problem, please check again.

11 дек. 2023 г., в 22:42, Max Bazarov @.***> написал(а):

Ohh. I was too fast with the latest fix. Merged uncompleted features into a release branch. Going to fix again.

11 дек. 2023 г., в 22:28, Lucas Marambio @.***> написал(а):



I'm also seeing an strange behavior with the frames exported as it seems that the navigation between frames does not work well now. When I click a frame that has the Navigate to another frame, the first frame does not hide, and the other one loads behind the first one. This behavior does not happen when playing the prototype on figma.

— Reply to this email directly, view it on GitHub https://github.com/MaxBazarov/demo-station-plugin/issues/6#issuecomment-1850743041, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEMQVAVZ722PNE7YSGSUARLYI5NFPAVCNFSM6AAAAABAQBHRPKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJQG42DGMBUGE. You are receiving this because you commented.

lucasmarambio commented 9 months ago

Not sure if I have to reload something to make this work, but I reopened figma, run the plugin, export the prototype and I still notice the frame navigation error.

Repro steps:

image

image

MaxBazarov commented 9 months ago

Sorry, but I can’ reproduce your issue. Here is an example which works well.



12 дек. 2023 г., в 01:05, Lucas Marambio @.***> написал(а):

Not sure if I have to reload something to make this work, but I reopened figma, run the plugin, export the prototype and I still notice the frame navigation error.

Repro steps:

On figma set a component on a frame with the following interaction: image.png (view on web) https://github.com/MaxBazarov/demo-station-plugin/assets/9018508/bd2a9254-eb56-497e-975d-7f747cf900cf Export project with the following config:

image.png (view on web) https://github.com/MaxBazarov/demo-station-plugin/assets/9018508/a9da77bf-eb30-4c37-813a-45e4035050c3 Open the exported site locally and click on the interaction, you will see that url changes but page is not refreshed, first frame is still present. image.png (view on web) https://github.com/MaxBazarov/demo-station-plugin/assets/9018508/dc8df72b-0015-448a-87f6-01f698aa8ee6 — Reply to this email directly, view it on GitHub https://github.com/MaxBazarov/demo-station-plugin/issues/6#issuecomment-1850965377, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEMQVAUXYQIYBOABG663ZGLYI57RLAVCNFSM6AAAAABAQBHRPKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJQHE3DKMZXG4. You are receiving this because you commented.