search

MaxBenChrist / tspreprocess

A Python package to preprocess time series
MIT License
60 stars 10 forks source link

Set default values for `compress` ? #6

Open nikhase opened 7 years ago

nikhase commented 7 years ago

How is it handled in tsfresh?

MaxBenChrist commented 7 years ago

How is it handled in tsfresh?

What do you mean? the settings?

nikhase commented 7 years ago

I changed my mind, I think there is no need for default settings (for column names, etc). I think, explicit is better than implicit in this case.

See in tsfresh:


def extract_features(timeseries_container, default_fc_parameters=None,
                     kind_to_fc_parameters=None,
                     column_id=None, column_sort=None, column_kind=None, column_value=None,
                     chunksize=defaults.CHUNKSIZE,
                     n_jobs=defaults.N_PROCESSES, show_warnings=defaults.SHOW_WARNINGS,
                     disable_progressbar=defaults.DISABLE_PROGRESSBAR,
                     impute_function=defaults.IMPUTE_FUNCTION,
                     profile=defaults.PROFILING,
                     profiling_filename=defaults.PROFILING_FILENAME,
                     profiling_sorting=defaults.PROFILING_SORTING):