search

MaxCDN / php-maxcdn

MaxCDN REST Web Services PHP Client
https://docs.maxcdn.com/
MIT License
19 stars 21 forks source link

Added bracket to follow PSR-2 #12

Closed iranianpep closed 8 years ago

iranianpep commented 8 years ago

In order to format the code based on PSR-2 standard I used phpfmt and it changed $endpoint = "$this->MaxCDNrws_url/$this->alias$selected_call"; to $endpoint = "$this->MaxCDNrws_url/$this->alias $selected_call"; (added space between $this->alias and $selected_call). To avoid it I used bracket. Also in the future we can format the entire code based on PSR-2

jdorfman commented 8 years ago

@iranianpep sorry this got overlooked. We will review it asap. Thanks

jdorfman commented 8 years ago

hey @iranianpep pulled your version and getting this:

"code": 404,
    "error": {
        "message": "Resource not found at \/maxcdn \/zones\/pull.json",
        "type": "RWS\\Exception"
    }
iranianpep commented 8 years ago

Hi Justin,

Strange. It's a really minor change. You can ignore this since it's been a long time and I'm not working on my project involved using this library anymore.

Cheers, Ehsan