MaxFour / Music-Player

Lightweight and Material designed Music Player
GNU General Public License v3.0
283 stars 71 forks source link

"Play Next" in "Up Next" view adds same song again to current playlist #56

Open pille opened 5 years ago

pille commented 5 years ago

Actual behaviour

In the "Up Next" view there's a list of tracks that will be played next. Let's call this a "playlist" for now, though that's probably something different in terms of this app.

In a tracks context menu the action "Play Next" adds the track (again) to this playlist at the top.

Expected behaviour

The track should be moved to the top.

Maybe that's intended behavior, but it doesn't make sense, since the playlist now contains a duplicate track. So when I use this feature to order the upcoming tracks, it ends up playing the same song multiple times (as it's still in its originally queued position).

So depending on how you interpret this issue, there are several solutions:

  1. move the tracks position in playlist, rather than duplicating it.
  2. labeling issue: a) rename the action to something like "Add to be played next" or "Add on Top" b) implement 1) as a new action for "Play Next" and also implement 2b)
MaxFour commented 5 years ago

Hello! Please take a screenshot of this issue. By default, tracks are added to the end of the playlist

pille commented 5 years ago

ScreenReord_2019-05-15-15-59-49 mp4

have a look at position 3: "outro"