MaxFour / Music-Player

Lightweight and Material designed Music Player
GNU General Public License v3.0
282 stars 71 forks source link

Can't add a large bunch of files to playlist #57

Open andropest opened 5 years ago

andropest commented 5 years ago

Actual behaviour

When I try to add a directory containing a large number of files it doesn't work. Sometimes a info box (Listing files) appears for a few seconds but nothing else happens. Sometimes not even the "Listing files" box appears. I tested some folders and the biggest one that worked contained 1903 files. The folders that I couldn't add contained between 2800 and 4500 files. I also tried to go into the folders, selected all files (select all), then tried to add to playlist, but this also didnt work.

The files are located on a sdcard (exfat filesystem). All other (many) players that I tested had no problems to add these files/folders to a playlist.

Steps to reproduce

  1. Go to the folders menu
  2. Select a directory containing a lot of files
  3. Select "Add to playlist"

I tested this on my Galaxy Tab S4 with Stock Oreo ROM and on my Note 9 with stock Pie ROM

Environment data

Android version: 8.1, 9.0

Device model: Samsung Galaxy Tab S4, Samsung Galaxy Note 9

Stock or customized system: Stock

Music-Player app version: 1.2.1

sjlongland commented 4 years ago

I find what happens is the dialogue disappears and the process grinds on in the background. Come back an hour later, the songs are all there and accounted for.

This is usually the case for me if I've just shut down the phone, pulled out its SD card and used rsync to transfer the songs on my laptop/desktop to the phone (which is often the most efficient way to do it if there's a lot of tracks).

So the feature does work, it just takes longer than the dialogue box suggests.

Device here is a ZTE T83 running Android 4.1 (OS as supplied by Telstra).