MaxGfeller / youtube-search

npm module to easily search youtube for videos
114 stars 40 forks source link

TypeScript fix + Change to promises #43

Closed N3bby closed 6 years ago

N3bby commented 6 years ago

Fixes invalid TypeScript in index.d.ts.

Also noticed that the Promise doesn't return the pageInfo object but only the search results. In order to fix this I had to create a new object: {results: YoutubeSearchResults[], pageInfo: YouTubeSearchPageResults} that wraps them both (since promises don't allow multiple objects to be returned when resolving)

Edit: Reference issue https://github.com/MaxGfeller/youtube-search/issues/41

TotomInc commented 6 years ago

That's actually the issue I found today, was going to make a fix but you made it well! :smile:

Please, merge this fast @MaxGfeller it is actually breaking my build.

MaxGfeller commented 6 years ago

That looks good to me, thanks for the fix @Razacx!

MaxGfeller commented 6 years ago

Relased as 1.1.1 🥂

caiusCitiriga commented 6 years ago

How a single notification can drastically improve your day. Thank you guys!