search

MaxGfeller / youtube-search

npm module to easily search youtube for videos
114 stars 40 forks source link

Exposed key in tests/test-search.js #45

Closed rb123454321 closed 6 years ago

rb123454321 commented 6 years ago

Don't know if it's fake or real, but just as a heads up.

MaxGfeller commented 6 years ago

Thanks for letting me know @rokoburilo! The key is just used for the automated tests and nothing else. But still - it makes no sense in exposing it.

I just changed this behavior in https://github.com/MaxGfeller/youtube-search/commit/1b10f72b336223ef79dd0537b09da16fd8a10e2c and added the key as a secret to Travis.