Closed ghost closed 5 years ago
The ring model is currently crossing over each individual with itself.
I had to stare at this to make sure my eyes weren't deceiving me.
In ModRing Apply():
ModRing
Apply()
var ( indi = pop.Individuals[i].Clone(pop.RNG) neighbour = pop.Individuals[i%len(pop.Individuals)] ) indi.Crossover(neighbour, pop.RNG)
I guess that's supposed to be (i+1)%len(...)
(i+1)%len(...)
The PR includes a couple other minor things.
LGTM! You made two good catches :). Thanks a lot.
The ring model is currently crossing over each individual with itself.
I had to stare at this to make sure my eyes weren't deceiving me.
In
ModRing
Apply()
:I guess that's supposed to be
(i+1)%len(...)
The PR includes a couple other minor things.