search

MaxHasADHD / TraktKit

Swift wrapper for Trakt.tv API.
MIT License
112 stars 37 forks source link

Support CocoaPods & Carthage #15

Closed filipejtdias closed 6 years ago

filipejtdias commented 6 years ago

Hi! This will only work if you create a tag "1.0.0" on master. If you find any trouble to test, please let me know.

MaxHasADHD commented 6 years ago

Can you update the readme.md with instructions of use

filipejtdias commented 6 years ago

Readme.md updated! You can consult this tutorial to publish properly the TraktKit pod. Release Pod Tutorial After the PR merged, I think you can create the tag and push the podspec (pod trunk push TraktKit.podspec)

MaxHasADHD commented 6 years ago

So I merged it then tried to push but kept encountering issues. Will need to look into this more I suppose.

MaxHasADHD commented 6 years ago

I'm seeing ``` -> TraktKit (1.0.0)

Can't find fix :/

filipejtdias commented 6 years ago

You don't have the tag created. Did you run the lint command?

MaxHasADHD commented 6 years ago

@filipejtdias I created / deleted the tag a few times, so when testing it was there. This is when running pod spec lint and I get errors for pod lib lint as well, passing in the local Podspec file. It doesn't like the HomePage URL, according to the URL. All forums I found on it had really no solution :/ I can create a new branch with the changes merged in and create the 1.0.0 tag again if it would show you the same thing?

MaxHasADHD commented 6 years ago

@filipejtdias when it was on your repo did linting work? what cocoa pods version were you on? I was on 1.4.0 I believe.

filipejtdias commented 6 years ago

Sorry Max for the delay. Yes, the lint worked with me and the cocoapods version was 1.4.0. Everything worked fine. Can you check if the Xcode Path location is well defined? If you run xcode-select -p on the terminal, the output should be something like this: /Applications/Xcode.app/Contents/Developer

filipejtdias commented 6 years ago

Any update on this?

MaxHasADHD commented 6 years ago

Hey @filipejtdias could you re-open a PR? I'll look into this tonight

filipejtdias commented 6 years ago

@MaxHasADHD Done: https://github.com/MaxHasADHD/TraktKit/pull/16

pahnev commented 6 years ago

@MaxHasADHD, if you’d add the 1.0 tag to the master branch, it would be easier for others to help. Once you’ve done it, you should have release in the https://github.com/MaxHasADHD/TraktKit/releases