MaxHasADHD / TraktKit

Swift wrapper for Trakt.tv API.
MIT License
112 stars 37 forks source link

Add missing TraktUser fields #38

Closed moritzsternemann closed 4 years ago

moritzsternemann commented 4 years ago

This PR adds the missing ids and images fields to TraktUser (documentation).

MaxHasADHD commented 4 years ago

@moritzsternemann Looks good, can you resolve conflicts and I'll get this merged.

moritzsternemann commented 4 years ago

Sure, done 🙃

cyberclectic commented 4 years ago

As User now conforms to Hashable from commit this commit. I believe this PR also needed to have the below also be Hashable

public struct IDs: Codable, Hashable {
        public let slug: String
    }

    public struct Images: Codable, Hashable {
        public let avatar: Image
    }

    public struct Image: Codable, Hashable {
        public let full: String
    }
MaxHasADHD commented 4 years ago

@cyberclectic Discovered this as well after merging. Working on this and some other updates. will have pushed up soon.