search

MaxHasADHD / TraktKit

Swift wrapper for Trakt.tv API.
MIT License
112 stars 37 forks source link

Conforming all models to Hashable #43

Closed zmknox closed 4 years ago

zmknox commented 4 years ago

Conforming all of TraktKit's models to Hashable both has no ill effects on its current functionality, and allows for one to use the model objects as identifiers, such as when using UICollectionViewDiffableDataSource.

This pull request adds Hashable to all Model structs, without modifying their functionality.

This pull request also contains a Package.swift file to support Swift Package Manager. I realize this is already covered in open PR #35, but with that PR being fairly stale (and tbh, my personal needs in my own project), I've added that here too.

bitomule commented 4 years ago

Yeah, I opened #35 long time ago but can't merge it. If this one gets merged I can just close mine.

MaxHasADHD commented 4 years ago

I'll look at this tonight, sorry!

MaxHasADHD commented 4 years ago

Thanks for doing this!