search

MaxHasADHD / TraktKit

Swift wrapper for Trakt.tv API.
MIT License
112 stars 37 forks source link

Title in TraktShowTranslation should be an optional String #52

Closed schaechtele closed 3 years ago

schaechtele commented 3 years ago

Hi @MaxHasADHD, first, thanks for your awesome work!

I found one issue when using the getShowTranslations method. As the translated title returned from Trakt can be empty, title should be an optional String in TraktShowTranslation. I received a parsing error and that's how I found out. I think that the title is empty in a translation when the title is the same as in the original language.

MaxHasADHD commented 3 years ago

Oh, thanks for letting me know! I'll look into getting that fixed

MaxHasADHD commented 3 years ago

@schaechtele The latest version (1.2.3) fixes this, and adds support for rate limits.

schaechtele commented 3 years ago

Great, thank you!!!