search

MaxHasADHD / TraktKit

Swift wrapper for Trakt.tv API.
MIT License
112 stars 37 forks source link

getPeopleInEpisode fails #56

Closed envoza closed 1 year ago

envoza commented 2 years ago

Hi, calls to getPeopleInEpisode fail due to "episode_count" not being present for episodes. In TVCastMember and TVCrewMember episodeCount needs to be optional to parse successfully.

The unit test for getPeopleInEpisode reports success, but actually fails and does not check the returned values as there is no check for the result being invalid. This appears to be the case with some other unit tests I've looked at.

I'm putting together a pull request (my first ever) with fixes for the model and test.

MaxHasADHD commented 1 year ago

@envoza Thank you for reporting, and sorry it's taken so long, I am pushing a fix out now.