Business Logic Not separated in specific unit

[hardion]

Exemple with AttenuationLevel :

ireg.cpp long ireg::get_attenuation(...) { std::string board = "boards."; std::string level_enum; mci_LevelNodeSet.Get(level_enum); std::string levelG = ".attenuation.gain_table."; std::string dB = ".dB"; std::string mci_LevelGNodeString = board + liberaBoard + levelG

• level_enum + dB; mci_LevelNodeGet = mci_application_root.GetNode( mci::Tokenize(mci_LevelGNodeString)); uint32_t v; mci_LevelNodeGet.Get(v);

}

LiberaSinglePassE.cpp : void LiberaSinglePassE::read_AttenuationLevel(Tango::Attribute &attr) { DEBUG_STREAM << "LiberaSinglePassE::readAttenuationLevel(Tango::Attribute &attr) entering... " << endl; /----- PROTECTED REGION ID(LiberaSinglePassE::readAttenuationLevel) ENABLED START -----/

try {
    *attr_AttenuationLevel_read = static_cast<Tango::DevLong>( long ireg::get_attenuation(...) );
} catch (istd::Exception &e) {
    ERROR_STREAM << "LiberaSinglePassE::read_AttenuationLevel failed "
            << device_name << e.what() << endl;
    return;
}

//  Set the attribute value
attr.set_value(attr_AttenuationLevel_read);

/*----- PROTECTED REGION END -----*/    //  LiberaSinglePassE::read_AttenuationLevel

}

[gasperjug]

There is only two classes that contain business logic, those are LiberaSinglePassE.cpp and LiberaSinglePassEDataTask.cpp and they have it all over the code. If we decide to separate it from tango, a complete change would be needed.

Is this really needed, or can we live with this two exceptions?