MaxIV-KitsControls / lib-maxiv-svgsynoptic

A library for creating control system synoptics using SVG
GNU Lesser General Public License v3.0
6 stars 8 forks source link

Python 3.6 and PyQt 5 compatibility #31

Closed wkitka closed 3 years ago

wkitka commented 4 years ago

Update lib-maxiv-svgsynoptic to be compatible with Python 3.6, Taurus 4.7, PyQt 5 and drop support for Python 2.

dschick commented 4 years ago

many thanks for putting this forward! It actually works like a charm for me.

However, when running the examples I need to rename the tango folder to something else, because the modules try to import this folder instead of the correct PyTango module.

After this change, both examples seem to work as expected. I was wondering, if a TaurusDevicePanel should open, when clicking onto one of the rectangles in the tango examples, which does not happens for me.

Best

Daniel

wkitka commented 4 years ago

Hej @dschick,

nice to hear it works for you! Yes, TaurusDevicePanel should appear, but I'm not sure if for every one of the rectangles. I tested it under CentOS 7 and Ubuntu 18.04 and TaurusDevicePanel appeared.

HEnquist commented 3 years ago

I believe only the rectangle in the center of the tango example should give a device panel or right-click. Renaming the tango example is probably a good idea, to avoid the import problem.

HEnquist commented 3 years ago

Isn't this change large enough to bump to 4.0.0?