search

MaxLap / standard-notes-indent-editor

A simple text editor that makes it easy to write and read nested notes in https://standardnotes.org/
GNU Affero General Public License v3.0
48 stars 2 forks source link

CMD/CTRL+Click does nothing when clicking on Hyperlinks #6

Closed christianhans closed 4 years ago

christianhans commented 4 years ago

MacOS 10.15.2 Standard Notes Desktop v3.0.25

MaxLap commented 4 years ago

Thanks for the report!

I didn't test the feature on the desktop version... wopsie! I use the browser version only...

I can see that it indeed doesn't work there. I will look into it.

MaxLap commented 4 years ago

This is fixed in the release I just made. (1.4.2) Thanks for the report!

christianhans commented 4 years ago

Thanks! Still doesn't seem to work for me. Tried both CMD+Click and CTRL+Click.

MaxLap commented 4 years ago

Did you try closing and restarting the app?

If you click on Extensions At the bottom left, you can hit '...' under Indent Editor. Can you confirm the version you see there is 1.4.2?

christianhans commented 4 years ago

Yes, version is 1.4.2. and I did try restarting the App. Issue occurs both on Home and Work Macbook. Chrome DevTools shows no JavaScript errors.

MaxLap commented 4 years ago

Did you try using the web SN to ctrl+click the same link? Does it work?

Could you paste me the exact string you have in your note? Maybe the link has something special in it that needs handling.

christianhans commented 4 years ago

Tried both CMD and CTRL+Click.

Link is https://www.google.com

Tried also Firefox and Safari - both don't work either.

christianhans commented 4 years ago

I also reinstalled the extension to make sure I am up to date.

MaxLap commented 4 years ago

Okay, I don't have a Mac, so it's hard to diagnose/fix. But I just did an attempt at a fix, available here: https://maxlap.github.io/standard-notes-indent-editor/demo.html Can you give that a try?

christianhans commented 4 years ago

Yes that works!

Opens the link in background on Safari/Chrome and in Foreground Tab on Firefox.

MaxLap commented 4 years ago

Those sound more like behavior of the browser than thing I have control of.

I released 1.4.3 with the fix. Might take a little while for it to propagate