python implementation is not working and not in sync with current implementation

MaxLaumeister / PageCrypt

Client-side password-protection for HTML

https://pagecrypt.maxlaumeister.com/

MIT License

506 stars 101 forks source link

python implementation is not working and not in sync with current implementation #25

Closed kmsaumcis closed 2 years ago

kmsaumcis commented 2 years ago

removed pad function it is no longer needed
removed dependency on unmaintained package
changed mode to AES.MODE_GCM to match current implementation in JS
added import to PBKDF2 implementation in maintained pycryptodome package
updated implementation to include 16B tag to end of encrypted payload

MaxLaumeister commented 2 years ago

Thank you for the patch, and thanks for being patient over the holidays! I've merged it.

The code looks good to me and I've tested it, but @gallizoltan if you have the bandwidth I would appreciate you giving this change set a quick once-over too, just to make sure there aren't any obvious issues I missed with the change of encryption modes and padding. Thanks!