MaxLeiter / sortablejs-vue3

A thin wrapper around Sortable.js for Vue 3
https://sortablejs-vue3.maxleiter.com
MIT License
379 stars 21 forks source link

Found ts declaration file but could not be resolved. #86

Open colinbes opened 1 year ago

colinbes commented 1 year ago

I am using vscode 1.78.2 together with vue 3.2.47 and latest vite.

I installed latest sortablejs-vue3 (1.2.9) as per instructions and am seeing error below.

I do see node_modules/sortablejs-vue3/dist/src/components/Sortable.vue.d.ts and the referred to node_modules/sortablejs-vue3/dist/types/main.d.ts but do not understand the comment on his result could not be resolved when respecting package.json

Could not find a declaration file for module 'sortablejs-vue3'. '/Users/colinbester/SynologyDrive/vite/recipe-manager/node_modules/sortablejs-vue3/dist/sortablejs-vue3.es.js' implicitly has an 'any' type.
  There are types at '/Users/colinbester/SynologyDrive/vite/recipe-manager/node_modules/sortablejs-vue3/dist/types/main.d.ts', but this result could not be resolved when respecting package.json "exports". The 'sortablejs-vue3' library may need to update its package.json or typings.ts(7016)

My vite tsconfig.json is setup under compilerOptions to use moduleResolution: "bundler"

Assistance appreciated.

neecto commented 1 year ago

Hey, I have the same issue with vite 4.3.9, vue 3.2.47

It seems to be just VS code issue, since the app build is successful and the package itself works. But still would be nice to know how to solve it.

@colinbes have you found a solution by any chance?

bbugh commented 1 year ago

A fix for this was already accepted in PR #84, we just need a new release to resolve the issue. @MaxLeiter what do you think about doing a point release of main to resolve this? It's the only new commit since the last release.

In the mean time if you are using npm or yarn you can use patch-package, or the built in pnpm patch with pnpm:

# patches/sortablejs-vue3@1.2.9.patch
diff --git a/package.json b/package.json
index 3092135c4b05748637ac0ca9fd4bde790a46ebca..54810888f0b88f5ee4d3ae3635e15a8c74c7dd77 100644
--- a/package.json
+++ b/package.json
@@ -30,6 +30,7 @@
   "module": "./dist/sortablejs-vue3.es.js",
   "exports": {
     ".": {
+      "types": "./dist/types/main.d.ts",
       "import": "./dist/sortablejs-vue3.es.js",
       "require": "./dist/sortablejs-vue3.umd.js"
     }