MaxMaeder / DriveBackupV2

Uploads Minecraft backups to Google Drive/OneDrive or by (S)FTP
https://dev.bukkit.org/projects/drivebackupv2
MIT License
158 stars 48 forks source link

Enhance "keep-count" setting and give an option to delete backups older than x time. #70

Open Raesak opened 3 years ago

Raesak commented 3 years ago

What feature do you want to see added?

I notice that when uploading to a cloud storage, the "keep-count" setting completely deletes excess backups (instead of sending them to the bin). I suggest adding a setting to toggle sending excess backups to the bin instead of completely deleting them.

Also I suggest adding a setting to automatically delete backups that are older than a configured number of days. This should also delete them from the cloud storage, and also have the setting to delete them to completely or send them to the bin.

Are there any alternatives?

No response

rhld16 commented 3 years ago

Due to the limitations of some cloud storage providers we are limited to sending the backup into the bin instead of permanently deleting it.

Addressing your second point, using the number of backups is better for most users since a certain number of backups are easier to account for instead of a time due to different schedules. The plugin does already delete the backups starting with the oldest

Raesak commented 3 years ago

we are limited to sending the backup into the bin instead of permanently deleting it.

I'm saying that in my cloud storage the plugin currently permanently deletes it. Not the other way around. Whenever I check my bin nothing is there, and the storage from the deleted items is freed up. If it has to be this way due to the limitations you mentioned, so be it.

Addressing your second point, using the number of backups is better for most users since a certain number of backups are easier to account for instead of a time due to different schedules. The plugin does already delete the backups starting with the oldest

I don't doubt that. I'm only suggesting an option for users to choose one way or another.

In my case specifically, I backup the server files as well as the MySQL databases. How it's working for me is that if I set the "keep-count" to 12, and the plugin is backing up 4 of my MySQL databases in addition to my server, there will be 4 zip folders for the MySQL backups (which is good, because there are 4 databases) and 1 zip folder for the server every time a backup is made.

But because "keep-count" is set to 12, it will only backup the 4 MySQL databases 3 times (which gives 12 folders) before it starts to delete them, while the server will be backed up a full 12 times before server folders start to get deleted.

So it is very lopsided when the "keep-count" setting functions like that when backing up multiple MySQL databases and only 1 server.

In this case, if old backups are deleted after a certain number of days instead, that solves the problem. Instead of deleting 3 day old MySQL database backups and 12 day old server backups due to the number of zip folders, it will simply delete whatever is a specified number of days old. That way, the age appropriate server zip folder and MySQL zip folders will always persist together.