search

MaxMelcher / AzureDevOps.WikiPDFExport

Export Azure DevOps Wiki to PDF
MIT License
191 stars 65 forks source link

Image Scaling Regex #18

Closed ahmadharis closed 4 years ago

ahmadharis commented 4 years ago

Description

Handles images with scaling attributes. The images with scaling attributes were currently ignored during conversion. Added an updated regex expression that handles this use-case. Tested on an internal wiki with 250+ pages and the conversion appears to work fine.

The regex expression specifically looks for .png, jpg, jpeg inside the parenthesis. The Regex expression can be adjusted to add support for future image types supported by Azure DevOps wiki.

Example

Below is a sample of the type of images that were not being converted.

Sample Input [devenv_Lbh7sFVc7K.png](/.attachments/devenv_Lbh7sFVc7K-a56f4c07-8738-4ab4-a363-12df4b9c05fe.png =90%x100%) Sample Output [devenv_Lbh7sFVc7K.png](/.attachments/devenv_Lbh7sFVc7K-a56f4c07-8738-4ab4-a363-12df4b9c05fe.png){width=90 height=100}

MaxMelcher commented 4 years ago

I pulled the regex, that seems fine. But to make it work, the pipeline needed to be changed, too. .UseAdvancedExtensions()

Thanks a lot for the fix!

ahmadharis commented 4 years ago

I pulled the regex, that seems fine. But to make it work, the pipeline needed to be changed, too. .UseAdvancedExtensions()

Thanks a lot for the fix!

Not sure how it worked for me without enabling Advanced Extensions. I used the local build to export a large wiki. Either way, glad that it is working now.