search

MaxMelcher / AzureDevOps.WikiPDFExport

Export Azure DevOps Wiki to PDF
MIT License
191 stars 65 forks source link

Added support for header-url and header-line #7

Closed roel4ez closed 4 years ago

roel4ez commented 5 years ago

header-url does not work in combination with header-right/header-left/header-center #6

roel4ez commented 5 years ago

I notice now that the default behavior has changed: the header-line is always visible in the current version. This PR changes the behavior to having it hidden if the argument is not provided.

I will update the PR.

roel4ez commented 5 years ago

Don't merge yet, I also see that the footer is no longer displayed when using header-url

roel4ez commented 5 years ago

I added support for footer-url. It seems that wkhtmltopdf does not like a mix of footer-* and header-* with footer-url and header-url.

I also added an example in the root on how such a header and footer could look like. (footer from https://wkhtmltopdf.org/usage/wkhtmltopdf.txt) Please let me know if you want to have more extended examples, or if I should put them in a /samples folder instead.

roel4ez commented 5 years ago

you can merge the PR whenever you're ready @MaxMelcher

MaxMelcher commented 4 years ago

Merged and released. Thank you @roel4ez - I tested the header-example and I like the cat picture :)