search

MaxNeedsSnacks / FTBQImporter

A small utility mod that lets you import Better Questing Quests and Loot Crates into FTB Quests
MIT License
3 stars 2 forks source link

Does not work for omnifactory #18

Closed PORTB closed 2 years ago

PORTB commented 3 years ago

When /ftbq_import quests` is run in a new world, the mod complains about having duplicate quests and orphaned quests. Upon relogging, the ftb quest book is missing many quests and also does not have the correct names/descriptions for any of the quests because a lang file is used for all the texts in better questing. The log file doesn't seem to have anything useful in it so I don't know what extra information to attach

MaxNeedsSnacks commented 3 years ago

Duplicate and orphaned quests are normal when working with Better Questing: Quests in FTB Quests are one-to-one and always tied to a chapter, while in BQ neither of those two conditions has to be fulfilled.

The fact that the book is missing some quests is a bit more problematic, can you send me a couple of examples of quests missing perhaps?

As for lang keys in names / descriptions, that's something I likely overlooked, but again, I'd appreciate the DefaultQuests.json attached as an example so I can hopefully implement this in the importer (for reference, FTB Quests can use lang keys like this {this.is.a.lang.key})

PORTB commented 3 years ago

Better questing (example 1) image (example 2) image

FTB quests (imported) (example 1) image (example 2) image

DefaultQuests.zip

MaxNeedsSnacks commented 3 years ago

Yeah, so, I figured that this is the case, but from playing Omnifactory I remember most of these quests existing in other chapters as well, for example the upgrade kits in the early / mid game chapter. I'm assuming they used the n-to-m "linking" that Better Questing has there (fun fact, this is also probably why some quests are showing up that aren't visible in the BQ book). I can attempt to make that look nicer, but it may not work exactly the same as it has pre-import (since that is practically impossible).

As for lang keys, I'll check that out later, but again that hopefully shouldn't be as difficult to implement ^^

TheAirBlow commented 2 years ago

Yeah, so, I figured that this is the case, but from playing Omnifactory I remember most of these quests existing in other chapters as well, for example the upgrade kits in the early / mid game chapter. I'm assuming they used the n-to-m "linking" that Better Questing has there (fun fact, this is also probably why some quests are showing up that aren't visible in the BQ book). I can attempt to make that look nicer, but it may not work exactly the same as it has pre-import (since that is practically impossible).

As for lang keys, I'll check that out later, but again that hopefully shouldn't be as difficult to implement ^^

1) A lot of the quests are deleted because of circular dependencies (according to logs) 2) It is indeed very easy to do, I even made a small program to do everything. Basically, you should replace %n with ",\n" (newline = new member in list), " with \", \ with \\.

TheAirBlow commented 2 years ago

@MaxNeedsSnacks please don't forget about existence of this project

MaxNeedsSnacks commented 2 years ago

Oh I didn't forget this exists, but honestly, with