search

MaxNeedsSnacks / roadrunner

A general-purpose performance mod and fork of the popular "Lithium" mod made for the Forge mod loader.
GNU Lesser General Public License v3.0
24 stars 5 forks source link

Incompatible with Simply Improved Terrain mod when using Better End Reforked #23

Closed Kaleidio closed 3 years ago

Kaleidio commented 3 years ago

reproduced in 1.16.5 by installing RoadRunner, Better End Reforked, and Simply Improved Terrain all in one go

[09:49:20] [main/INFO]: [java.lang.Throwable:printEnclosedStackTrace:709]: Caused by: org.spongepowered.asm.mixin.injection.throwables.InjectionError: Critical injection failure: Redirector handleNoiseSample(Lnet/minecraft/world/gen/SimplexNoiseGenerator;II)F in roadrunner.mixins.json:gen.fast_island_noise.TheEndBiomeSourceMixin failed injection check, (0/1) succeeded. Scanned 1 target(s). Using refmap RoadRunner-mc1.16.5-refmap.json

Causes immediate crash on init stage

Kaleidio commented 3 years ago

Seems like this is because you implemented your own version of a simple terrain noise type. I understand if you don't wanna fix this crash as honestly I'd prefer yours. but it would be a good idea to tell your users these two terrain mods are incompatible.

MaxNeedsSnacks commented 3 years ago

As you already kind of said, this is on SIT, see https://github.com/MaxNeedsSnacks/roadrunner/issues/5#issuecomment-932954008 ^^

I don't really want to make RR explicitly incompatible with other mods (other than conflicting performance mods, obviously), since mods can just disable RR patches that would make the game act up otherwise